Make sure a blank title string resets the title#17802
Merged
lhecker merged 1 commit intomicrosoft:mainfrom Aug 26, 2024
Merged
Conversation
microsoft-github-policy-service
bot
added
the
Issue-Bug
zadjii-msft
approved these changes
Aug 26, 2024
lhecker
approved these changes
Aug 26, 2024
microsoft-github-policy-service
bot
added
Area-VT
DHowett
reviewed
Sep 4, 2024
Member
DHowett
left a comment
DHowett
left a comment
There was a problem hiding this comment.
Thanks! I'm marking this up for servicing to 1.22.
DHowett
pushed a commit
that referenced
this pull request
Sep 4, 2024
## Summary of the Pull Request When a VT title sequence sets the title to a blank string, that is meant to trigger a reset to the default starting value. This used to work in the past because the blank value was dealt with by conhost, so Windows Terminal never received a blank title, but that's no longer the case with the new VT passthrough. This PR fixes the issue by getting Windows Terminal to handle the blank title strings itself. ## References and Relevant Issues VT passthrough was introduced in PR #17510. ## Validation Steps Performed I've manually verified that the `OSC 0`, `OSC 2`, and `DECSWT` sequences now correctly reset the title when passed a blank title string. ## PR Checklist - [x] Closes #17800 (cherry picked from commit 1f71568) Service-Card-Id: PVTI_lADOAF3p4s4AmhmQzgSNvr0 PVTI_lADOAF3p4s4AmhmQzgSOFrc Service-Version: 1.22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
When a VT title sequence sets the title to a blank string, that is meant
to trigger a reset to the default starting value. This used to work in
the past because the blank value was dealt with by conhost, so Windows
Terminal never received a blank title, but that's no longer the case
with the new VT passthrough. This PR fixes the issue by getting Windows
Terminal to handle the blank title strings itself.
References and Relevant Issues
VT passthrough was introduced in PR #17510.
Validation Steps Performed
I've manually verified that the
OSC 0,OSC 2, andDECSWTsequencesnow correctly reset the title when passed a blank title string.
PR Checklist