Skip to content

Remove some unused TextBuffer methods#17443

Merged
lhecker merged 2 commits intomainfrom
dev/lhecker/textbuffer-cleanup
Jun 20, 2024
Merged

Remove some unused TextBuffer methods#17443
lhecker merged 2 commits intomainfrom
dev/lhecker/textbuffer-cleanup

Conversation

@lhecker
Copy link
Member

@lhecker lhecker commented Jun 19, 2024

This is simply some unused code from the days before the big
text buffer rewrite in #13626.

@lhecker lhecker added the Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. label Jun 19, 2024
TextAttribute attr{ 0x7f };
auto _buffer = std::make_unique<TextBuffer>(bufferSize, attr, cursorSize, false, _renderer);

// This is the burrito emoji: 🌯
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

goodbye sweet burrito test

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have more complex tests in its place now (just below this one IIRC). 😌

@lhecker lhecker added this pull request to the merge queue Jun 20, 2024
Merged via the queue into main with commit e0686fa Jun 20, 2024
@lhecker lhecker deleted the dev/lhecker/textbuffer-cleanup branch June 20, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants