Re-implement previewing, with the new TSF#17386
Merged
zadjii-msft merged 9 commits intomainfrom Jun 11, 2024
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return; | ||
| } | ||
|
|
||
| // When we're previewing suggestions, they might be preceeded with DEL |
Check failure
Code scanning / check-spelling
Unrecognized Spelling
microsoft-github-policy-service
bot
added
Issue-Task
Member
Author
|
Gifs:
|
lhecker
approved these changes
Jun 10, 2024
Member
lhecker
left a comment
lhecker
left a comment
There was a problem hiding this comment.
Just nits + the cursorPos thing.
2 tasks
DHowett
reviewed
Jun 11, 2024
DHowett
reviewed
Jun 11, 2024
DHowett
reviewed
Jun 11, 2024
DHowett
reviewed
Jun 11, 2024
carlos-zamora
approved these changes
Jun 11, 2024
Member
carlos-zamora
left a comment
carlos-zamora
left a comment
There was a problem hiding this comment.
Looks and feels great! Approving, though you'll probably wanna address the nits Dustin's found.
carlos-zamora
approved these changes
Jun 11, 2024
DHowett
approved these changes
Jun 11, 2024
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for previewing snippets, again. This time, with the new TSF implementation. Leonard pointed me in the right direction with this - he's the one who suggested to have a second
Compositionjust for previews like this.Then we do some tricky magic to make it work when we're using commandlines from shell integration, or you've got the ghost text from powershell, etc. Then we visualize the control codes, just so they aren't just U+FFFE diamonds.
Closes #12861