Also remember to persist window positions#17066
Conversation
| const auto launchPosRequest{ winrt::make<LaunchPositionRequest>() }; | ||
| RequestLaunchPosition.raise(*this, launchPosRequest); | ||
| layout.InitialPosition(launchPosRequest.Position()); |
There was a problem hiding this comment.
BTW as I mentioned briefly in #12633 we should probably use GetWindowPlacement here. It only needs the HWND which the TerminalPage already knows about. The struct could then be serialized to a JSON object. It even got WPF_ASYNCWINDOWPLACEMENT which may be useful for us: https://learn.microsoft.com/en-us/windows/win32/api/winuser/ns-winuser-windowplacement
There was a problem hiding this comment.
Yes, though, we may also want to be careful about how that plays with focus mode too. Since forever, session restore + fomo has restored at the wrong size, I think wrongly including the size of the tab row. (I cannot for the life of me find that issue though)
|
Hey, does this apply to #17049 as well? |
I'd guess that it does. The simple check is if anyone is still calling |
This got lost in #16598. `TerminalPage` needs to ask the window where the it actually is, so it can persist it. More details in #16598 (comment) Closes #17010 (cherry picked from commit 643f716) Service-Card-Id: 92360686 Service-Version: 1.20
4 participants
This got lost in #16598.
TerminalPageneeds to ask the window where the it actually is, so it can persist it. More details in #16598 (comment)Closes #17010