Merged
Conversation
…/fhl/scratchpad-pane
…/fhl/scratchpad-pane
…rminal-panes-2023
…/fhl/scratchpad-pane
lhecker
approved these changes
Apr 3, 2024
DHowett
reviewed
Apr 3, 2024
| const auto profileDefaults{ _settings.ProfileDefaults() }; | ||
| const auto allProfiles{ _settings.AllProfiles() }; | ||
|
|
||
| profileGuidSettingsMap.reserve(allProfiles.Size() + 1); |
Member
There was a problem hiding this comment.
don't we need to clear the profileGuidSettingsMap?
DHowett
requested changes
Apr 5, 2024
Member
DHowett
left a comment
DHowett
left a comment
There was a problem hiding this comment.
Just blocking for my question - otherwise this looks good!
microsoft-github-policy-service
bot
added
the
Needs-Author-Feedback
microsoft-github-policy-service
bot
removed
the
Needs-Author-Feedback
DHowett
approved these changes
Apr 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As @lhecker noted in the #16172 review,
UpdateTerminalSettingsis wacky. We can just pass the cache in at the start, then reset it and reuse it inUpdateSettings. One fewertry_as!