Add a pile of 'experimental' settings to the profile SUI#16809
Merged
zadjii-msft merged 2 commits intomainfrom Mar 21, 2024
Merged
Add a pile of 'experimental' settings to the profile SUI#16809zadjii-msft merged 2 commits intomainfrom
zadjii-msft merged 2 commits intomainfrom
Conversation
lhecker
reviewed
Mar 4, 2024
Member
|
nit: reword commit title to be imperative ("this commit will...") |
microsoft-github-policy-service
bot
added
the
Needs-Tag-Fix
zadjii-msft
changed the title
lhecker
approved these changes
Mar 4, 2024
carlos-zamora
approved these changes
Mar 18, 2024
Member
carlos-zamora
left a comment
carlos-zamora
left a comment
There was a problem hiding this comment.
Just some nits on the resw. Approving since it'll be a quick fix.
src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
Outdated
Show resolved
Hide resolved
src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
Outdated
Show resolved
Hide resolved
1 task
carlos-zamora
approved these changes
Mar 21, 2024
zadjii-msft
deleted the
dev/migrie/b/add-missing-experimental-prof-settings
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted in #3337, we never actually added this menu to the settings.
Since we're planning on taking this out of "experimental" in 1.21, we should have a visible setting for it too.