App now initializes the connection instead of term control.#1676
Merged
PankajBhojwani merged 2 commits intomicrosoft:masterfrom Jun 28, 2019
Merged
App now initializes the connection instead of term control.#1676PankajBhojwani merged 2 commits intomicrosoft:masterfrom
PankajBhojwani merged 2 commits intomicrosoft:masterfrom
Conversation
DHowett-MSFT
approved these changes
Jun 27, 2019
Contributor
DHowett-MSFT
left a comment
DHowett-MSFT
left a comment
There was a problem hiding this comment.
I love this so much.
miniksa
approved these changes
Jun 28, 2019
mcpiroman
pushed a commit
to mcpiroman/terminal
that referenced
this pull request
Jul 2, 2019
…t#1676) * App now initializes the connection instead of term control.
mcpiroman
pushed a commit
to mcpiroman/terminal
that referenced
this pull request
Jul 23, 2019
…t#1676) * App now initializes the connection instead of term control.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
We want TermControl to be agnostic to the type of connection, so the connection initialization has been moved to TerminalApp.
References
PR Checklist
Detailed Description of the Pull Request / Additional comments
The TermControl constructor has been modified to take in a connection, thus TermControl does not need to initialize a connection anymore. Instead, TerminalApp initializes the connection and passes it into the TermControl constructor. Thus once we start allowing different types of connections (an Azure connection for example), the detection of the type of connection only needs to happen in TerminalApp.
Validation Steps Performed