Avoid generating extra formatted copies when no action specific copyFormatting is set#16480
Merged
microsoft-github-policy-service[bot] merged 2 commits intomicrosoft:mainfrom Jan 24, 2024
Conversation
lhecker
approved these changes
Jan 10, 2024
zadjii-msft
approved these changes
Jan 19, 2024
zadjii-msft
added
the
AutoMerge
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid generating extra formatted copies when action's
copyFormattingis not present and globally setcopyFormattingis used.Previously, when the action's
copyFormattingwasn't set we deferred the decision of which formats needed to be copied to theTerminalPage::CopyToClipboardhandler. This meant we needed to copy the text in all the available formats and pass it to the handler to copy the required formats after querying the globalcopyFormatting.To avoid making extra copies, we'll store the global
copyFormattingin TerminalSettings and pass it down toTermControl. IfControlCore::CopySelectionToClipboard()doesn't receive action specificcopyFormatting, it will fall back to the global one before generating the texts.Validation Steps Performed
copyFormattingset for the copy action: Copies formats according to the globalcopyFormatting.copyFormattingis set for the copy action: Copies formats according to the action'scopyFormatting.