Improve performance of scrollbar marks#16006
Merged
microsoft-github-policy-service[bot] merged 1 commit intomainfrom Sep 20, 2023
Merged
Improve performance of scrollbar marks#16006microsoft-github-policy-service[bot] merged 1 commit intomainfrom
microsoft-github-policy-service[bot] merged 1 commit intomainfrom
Conversation
microsoft-github-policy-service
bot
added
Issue-Bug
DHowett
approved these changes
Sep 20, 2023
lhecker
added
the
AutoMerge
microsoft-github-policy-service
bot
deleted the
dev/lhecker/15955-optimize-scrollbar-marks
branch
carlos-zamora
pushed a commit
that referenced
this pull request
Sep 22, 2023
When launching a debug Terminal, `_initializedTerminal` might still be false and the scrollbar might still be 0px tall. This causes the `assert(false)` condition within `_throttledUpdateScrollbar` to be hit. Regressed in #16006
DHowett
pushed a commit
that referenced
this pull request
Oct 17, 2023
Guess what _doesn't_ have the same layout as a bitmap? A `til::color`. Noticed in 1.19. Regressed in #16006
DHowett
pushed a commit
that referenced
this pull request
Oct 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the use of a
<Canvas>with an<Image>for drawingscrollbar marks. Otherwise, WinUI struggles with the up to ~9000 UI
elements as they get dirtied every time the scrollbar moves.
(FWIW 9000 is not a lot and it should not struggle with that.)
The
<Image>element has the benefit that we can get hold of a CPU-sidebitmap which we can manually draw our marks into and then swap them into
the UI tree. It draws the same 9000 elements, but now WinUI doesn't
struggle anymore because only 1 element gets invalidated every time.
Closes #15955
Validation Steps Performed