Skip to content

Manually close the ContentDialog in teardown#15387

Merged
zadjii-msft merged 1 commit intomainfrom
dev/migrie/b/15364-close-the-contentdialog-manually
May 22, 2023
Merged

Manually close the ContentDialog in teardown#15387
zadjii-msft merged 1 commit intomainfrom
dev/migrie/b/15364-close-the-contentdialog-manually

Conversation

@zadjii-msft
Copy link
Member

As discussed. Closes #15364.

Prevents one crash on Windows 10. Opens the door to may more horrors.

Co-authored by: @j4james

As discussed. Closes #15364.

Prevents one crash on Windows 10. Opens the door to may more horrors.

Co-authored by: @j4james
@microsoft-github-policy-service microsoft-github-policy-service bot added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-Windowing Window frame, quake mode, tearout Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. labels May 19, 2023
@DHowett
Copy link
Member

DHowett commented May 19, 2023

You will need to use the Signed-off-by: Name <e-mail> format when you actually merge this

Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure @lhecker sees this too

@zadjii-msft zadjii-msft merged commit 910c61b into main May 22, 2023
@zadjii-msft zadjii-msft deleted the dev/migrie/b/15364-close-the-contentdialog-manually branch May 22, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Windowing Window frame, quake mode, tearout Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows Terminal throws an exception on exit

3 participants