Fix WindowEmperor exiting too early#15337
Merged
microsoft-github-policy-service[bot] merged 1 commit intomainfrom May 12, 2023
Merged
Fix WindowEmperor exiting too early#15337microsoft-github-policy-service[bot] merged 1 commit intomainfrom
microsoft-github-policy-service[bot] merged 1 commit intomainfrom
Conversation
lhecker
added
Issue-Bug
lhecker
commented
May 11, 2023
| void RundownForExit(); | ||
|
|
||
| winrt::Microsoft::Terminal::Remoting::Peasant Peasant(); | ||
| uint64_t PeasantID(); |
Member
Author
There was a problem hiding this comment.
I made this change because it avoids exposing the innards of WindowThread. It's technically unrelated.
zadjii-msft
approved these changes
May 12, 2023
Member
zadjii-msft
left a comment
zadjii-msft
left a comment
There was a problem hiding this comment.
multiple threads are hard man. Thanks for cleaning up my mess.
DHowett
approved these changes
May 12, 2023
| void RundownForExit(); | ||
|
|
||
| winrt::Microsoft::Terminal::Remoting::Peasant Peasant(); | ||
| uint64_t PeasantID(); |
lhecker
added
the
AutoMerge
microsoft-github-policy-service
bot
deleted the
dev/lhecker/15306-shutdown-fix
branch
DHowett
pushed a commit
that referenced
this pull request
May 12, 2023
`WindowEmperor` would exit as soon as the last window would enter `RundownForExit()`, which is too early and triggers leak checks. This commit splits up the shutdown up into deregistering the window from the list of windows and into actually decrementing the window count. Closes #15306 ## Validation Steps Performed * D2D leak warnings seem to disappear ✅ (cherry picked from commit 488de2d) Service-Card-Id: 89180861 Service-Version: 1.18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WindowEmperorwould exit as soon as the last window would enterRundownForExit(), which is too early and triggers leak checks.This commit splits up the shutdown up into deregistering the window from
the list of windows and into actually decrementing the window count.
Closes #15306
Validation Steps Performed