Add support to show close button for active tab only.#15237
Merged
microsoft-github-policy-service[bot] merged 2 commits intomicrosoft:mainfrom May 3, 2023
Merged
Conversation
microsoft-github-policy-service
bot
added
Issue-Task
kovdu
changed the title
zadjii-msft
approved these changes
Apr 26, 2023
Member
zadjii-msft
left a comment
zadjii-msft
left a comment
There was a problem hiding this comment.
Yep that's literally how I'd do it 😝 Thanks!
carlos-zamora
approved these changes
May 2, 2023
Member
DemoSmall demo of the result: NOTE: removed the demo from the PR body so that the commit history is a bit cleaner |
Member
|
@kovdu I'm not going to merge this yet to give you some time to apply/respond to my comments, but the PR is good to go! Again, thanks for the contribution! |
Contributor
Author
|
Thanks for the feedback @carlos-zamora . Fixed your remarks, updated Also verified the new value is correctly applied when hot reloading the settings file. |
zadjii-msft
added
the
AutoMerge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR introduces
activeOnlyfor theshowCloseButtontheme option causing the close button only to appear on the active tab.This is more or less following the approach explained here Terminal Walkthroughs (view) which indeed just works 😄 .
You notice when switching theme the close buttons is back on all tabs again as well.
Closes #13672
I didn't check specific unit tests for this. I hope by making this MR the pipeline will show if I broke something. Or just let me know if you want me to add something specific for this.