Fix a crash on startup with a folder entry without entries#14629
Merged
5 commits merged intomainfrom Jan 19, 2023
Merged
Conversation
ghost
added
Area-CodeHealth
Member
|
If having an empty folder is invalid, shouldn't we throw a serialization error or warning? |
DHowett
reviewed
Jan 13, 2023
DHowett
requested changes
Jan 13, 2023
Member
DHowett
left a comment
DHowett
left a comment
There was a problem hiding this comment.
(only not signing off because of the GetValueForKey<T> thing)
ghost
added
the
Needs-Author-Feedback
carlos-zamora
added a commit
that referenced
this pull request
Jan 14, 2023
ghost
removed
the
Needs-Author-Feedback
Member
Author
A warning might be nice, sure, but it's not well hooked up for that right now, and we do need the crash fix NOW. I feel like this is one of those "you aint gonna fix it" things. |
carlos-zamora
approved these changes
Jan 18, 2023
DHowett
approved these changes
Jan 18, 2023
DHowett
added
the
AutoMerge
|
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
|
🎉 Handy links: |
ghost
mentioned this pull request
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_Entrieswas getting default constructed tonullptr. We should be careful about that.Adds a test too, and fixes a regression in the local tests introduced in #13763.
Closes #14557