Add an action for immediately restarting a connection#14549
Closed
zadjii-msft wants to merge 6 commits intodev/migrie/b/cxn-restarting-attempt-1-backportfrom
Closed
Add an action for immediately restarting a connection#14549zadjii-msft wants to merge 6 commits intodev/migrie/b/cxn-restarting-attempt-1-backportfrom
zadjii-msft wants to merge 6 commits intodev/migrie/b/cxn-restarting-attempt-1-backportfrom
Conversation
ghost
added
Area-TerminalControl
This comment has been minimized.
This comment has been minimized.
lhecker
approved these changes
Jan 20, 2023
…v/migrie/f/3726-restartConnection
This was referenced Mar 13, 2023
Closed
…v/migrie/f/3726-restartConnection
This comment has been minimized.
This comment has been minimized.
DHowett
added a commit
that referenced
this pull request
Apr 6, 2023
# Conflicts: # src/cascadia/TerminalApp/TerminalPage.cpp # src/cascadia/TerminalConnection/ConptyConnection.h # src/cascadia/TerminalConnection/ConptyConnection.idl # src/cascadia/TerminalControl/ControlCore.cpp # src/cascadia/TerminalControl/ControlCore.idl # src/cascadia/TerminalControl/TermControl.cpp # src/cascadia/TerminalSettingsModel/Resources/en-US/Resources.resw
Member
Author
|
Remember when we all bashed this and restarting live connections exploded? Yea I can't get that anymore. Maybe it was a bad merge? Maybe it was a bad pre-merge? Hard to say. |
…v/migrie/f/3726-restartConnection
Member
Author
|
Closed in favor of #15241 |
DHowett
pushed a commit
that referenced
this pull request
Apr 28, 2023
Adds an action for immediately restarting the connection. I suspect most folks that wanted #3726 will be happy just with the <kbd>enter</kbd> solution from #14060, but this will work without having to `exit` the client. Just, relaunch whatever the commandline is. Easy peasy. Closes #3726. Obsoletes #14549
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
targets #14548
Adds an action for immediately restarting the connection. I suspect most folks that wanted #3726 will be happy just with the enter solution from #14060, but this will work without having to
exitthe client. Just, relaunch whatever the commandline is. Easy peasy.Closes #3726.