Skip to content

Make about dialog content copyable#1452

Merged
DHowett-MSFT merged 1 commit intomicrosoft:masterfrom
Summon528:about-select
Jun 24, 2019
Merged

Make about dialog content copyable#1452
DHowett-MSFT merged 1 commit intomicrosoft:masterfrom
Summon528:about-select

Conversation

@Summon528
Copy link
Contributor

@Summon528 Summon528 commented Jun 23, 2019

Summary of the Pull Request

Make about dialog content copyable

References

PR Checklist

  • Closes About dialog should have a copy button #1335
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Wrap aboutText with a selectable text block.

Validation Steps Performed

DHowett-MSFT
DHowett-MSFT approved these changes Jun 23, 2019
View reviewed changes
Copy link
Contributor

@DHowett-MSFT DHowett-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Thanks!

Clever use of the IInspectable parameter. 😄

@DHowett-MSFT
Copy link
Contributor

DHowett-MSFT commented Jun 23, 2019

It's a ContentDialog whose Content is a boxed HSTRING. This makes it the TextBlock you're suggesting we set IsTextSelectionEnabled on.

@DHowett-MSFT
Copy link
Contributor

DHowett-MSFT commented Jun 23, 2019

(Terminal doesn't use .xaml files, which is something we know we need to fix, etc.)

@mdtauk
Copy link

mdtauk commented Jun 23, 2019 •
edited
Loading

It's a ContentDialog whose Content is a boxed HSTRING. This makes it the TextBlock you're suggesting we set IsTextSelectionEnabled on.

I asked the question, checked the code change, and saw the property being used. Can't normally understand C++ code, so I spoke before checking lol

(Terminal doesn't use .xaml files, which is something we know we need to fix, etc.)

Xaml Direct?

@DHowett-MSFT DHowett-MSFT merged commit 0fba910 into microsoft:master Jun 24, 2019
@cpbotha cpbotha mentioned this pull request Jun 28, 2019
Closed
DHowett-MSFT pushed a commit that referenced this pull request Jul 2, 2019
@DHowett
Make the about dialog's contents selectable (#1452)
08e8f37 
(cherry picked from commit 0fba910)
@DHowett-MSFT DHowett-MSFT mentioned this pull request Jul 2, 2019
Merged
DHowett-MSFT pushed a commit that referenced this pull request Jul 2, 2019
@DHowett
Make the about dialog's contents selectable (#1452)
c833c93 
(cherry picked from commit 0fba910)
mcpiroman pushed a commit to mcpiroman/terminal that referenced this pull request Jul 2, 2019
@mcpiroman
Make the about dialog's contents selectable (microsoft#1452)
aa2f5f5
@Summon528 Summon528 deleted the about-select branch July 4, 2019 09:47
mcpiroman pushed a commit to mcpiroman/terminal that referenced this pull request Jul 23, 2019
@mcpiroman
Make the about dialog's contents selectable (microsoft#1452)
29eb59d
@zadjii-msft zadjii-msft mentioned this pull request Nov 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carlos-zamora carlos-zamora carlos-zamora approved these changes

+1 more reviewer

@DHowett-MSFT DHowett-MSFT DHowett-MSFT approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

About dialog should have a copy button

4 participants

@Summon528 @DHowett-MSFT @mdtauk @carlos-zamora