Fix setting launch position in the Settings UI not working#14518
Merged
1 commit merged intomainfrom Dec 9, 2022
Merged
Conversation
ghost
added
Area-SettingsUI
carlos-zamora
approved these changes
Dec 9, 2022
carlos-zamora
added
the
AutoMerge
|
Hello @carlos-zamora! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
Member
|
@PankajBhojwani was launch position UI part of 1.16? |
Contributor
|
There's still something a bit funky with this: LaunchPosition.mp4 |
Contributor
|
^ This is fixed in #14522 |
ghost
pushed a commit
that referenced
this pull request
Dec 13, 2022
) Ensures the X & Y XAML controls are updated when the default launch position checkbox is toggled. References #14518
|
🎉 Handy links: |
ghost
mentioned this pull request
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This change should have been a part of #14190 but was missed.
PR Checklist
Validation Steps Performed
Setting launch position in the settings UI works now