Skip to content

Ensure reading the buffer content actually returns the content#14379

Merged
1 commit merged intomicrosoft:mainfrom
ianjoneill:b-unable-to-export-buffer-text
Nov 12, 2022
Merged

Ensure reading the buffer content actually returns the content#14379
1 commit merged intomicrosoft:mainfrom
ianjoneill:b-unable-to-export-buffer-text

Conversation

@ianjoneill
Copy link
Contributor

@ianjoneill ianjoneill commented Nov 12, 2022 •
edited
Loading

Summary of the Pull Request

Ensures that reading the buffer content actually returns the content.

References

Regressed in #13626.

PR Checklist

Validation Steps Performed

Added a test.

@ghost ghost added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Nov 12, 2022
@ianjoneill
Copy link
Contributor Author

ianjoneill commented Nov 12, 2022

The CI hates me.

Error: Verify: IsLessThan(tries, 5): Make sure we set up the new console in time - Values (5, 5) [File: C:\a\_work\1\s\src\host\ft_host\InitTests.cpp, Function: ModuleSetup, Line: 280]
Error: TAEF: Setup fixture 'ModuleSetup' for the scope 'C:\a\_work\1\a\drop\Release\x64\test\ConHost.Feature.Tests.dll' failed.

zadjii-msft
zadjii-msft approved these changes Nov 12, 2022
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@zadjii-msft zadjii-msft added AutoMerge Marked for automatic merge by the bot when requirements are met Needs-Second It's a PR that needs another sign-off labels Nov 12, 2022
@ghost
Copy link

ghost commented Nov 12, 2022

Hello @zadjii-msft!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 6 hours 53 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

DHowett
DHowett approved these changes Nov 12, 2022
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sheesh good catch!

lhecker
lhecker approved these changes Nov 12, 2022
View reviewed changes
Copy link
Member

@lhecker lhecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oof... Thanks for catching this!

GetText() is now returning a wstring_view which doesn't have the previous replace() member function. So I checked all other callers of GetText() in #13626 and fortunately this was the only code that had any meaningful changes.

@ghost ghost merged commit 6b4b63b into microsoft:main Nov 12, 2022
@ghost
Copy link

ghost commented Jan 24, 2023

🎉Windows Terminal Preview v1.17.1023 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Jan 24, 2023
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DHowett DHowett DHowett approved these changes

@lhecker lhecker lhecker approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@PankajBhojwani PankajBhojwani Awaiting requested review from PankajBhojwani

@carlos-zamora carlos-zamora Awaiting requested review from carlos-zamora

Assignees

No one assigned

Labels

AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Second It's a PR that needs another sign-off

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Buffer exports only contain spaces

4 participants

@ianjoneill @DHowett @lhecker @zadjii-msft