Update LaunchPosition to use int32_t instead of int64_t#14190
Merged
1 commit merged intomainfrom Oct 12, 2022
Merged
Conversation
lhecker
approved these changes
Oct 12, 2022
DHowett
approved these changes
Oct 12, 2022
Member
DHowett
left a comment
DHowett
left a comment
There was a problem hiding this comment.
cool but it doesn't compile ;P
Member
|
My bad; apparently nuget can't be trusted for anything. |
PankajBhojwani
added
the
AutoMerge
|
Hello @PankajBhojwani! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
6 tasks
ghost
pushed a commit
that referenced
this pull request
Dec 9, 2022
## Summary of the Pull Request This change should have been a part of #14190 but was missed. ## PR Checklist * [x] Closes #14469 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [ ] Schema updated. * [x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx ## Validation Steps Performed Setting launch position in the settings UI works now
|
🎉 Handy links: |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #13730 merged, when we parse LaunchPosition we treat the
coordinates as
int32_t. This PR updates the actualLaunchPositionstruct to also use
int32_tfor consistency.Validation Steps Performed
Terminal still builds and runs