Merged
Conversation
carlos-zamora
approved these changes
Aug 1, 2022
zadjii-msft
approved these changes
Aug 2, 2022
Member
zadjii-msft
left a comment
zadjii-msft
left a comment
There was a problem hiding this comment.
Sure, let's go for it. GDI doesn't have the bitmap for invalidation so we don't really need to worry about changing the invalid map to just a singular array of invalid rows (akin to dx). I'm cool with this.
lhecker
added
the
AutoMerge
|
Hello @lhecker! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue were overwriting parts of a row would only trigger
that specific portion of the row to be redrawn. This isn't just
problematic for combining characters, but also for things like
the new
TestDbcsBisectWriteCellstest introduced in #13626.Benchmarks showed no impact on performance whatsoever.
Validation Steps Performed
TestDbcsBisectWriteCellstest and break before OpenConsole exits