Add support for setting a profile's tab title#1358
Merged
cinnamon-msft merged 7 commits intomasterfrom Jul 2, 2019
Merged
Conversation
cinnamon-msft
requested review from
DHowett-MSFT,
adiviness,
carlos-zamora,
miniksa and
zadjii-msft
miniksa
requested changes
Jun 21, 2019
ghost
added
Needs-Author-Feedback
adiviness
approved these changes
Jun 21, 2019
DHowett-MSFT
previously requested changes
Jun 21, 2019
ghost
added
the
Needs-Author-Feedback
Contributor
|
nit: title should be more like |
cinnamon-msft
changed the title
ghost
removed
the
Needs-Author-Feedback
Contributor
zadjii-msft
reviewed
Jul 1, 2019
Member
zadjii-msft
left a comment
zadjii-msft
left a comment
There was a problem hiding this comment.
Frankly my only major comment is a nit. Nice work!
zadjii-msft
approved these changes
Jul 1, 2019
miniksa
reviewed
Jul 1, 2019
miniksa
approved these changes
Jul 1, 2019
Co-Authored-By: Michael Niksa <[email protected]>
DHowett-MSFT
dismissed
their stale review
I don't agree that we need this feature, but I refuse to continue holding it up.
carlos-zamora
approved these changes
Jul 2, 2019
|
Is this included in 0.2.1831.0 from the Windows Store? I tried to add the tabTitle to the JSON and it gets deleted every time I open the app. |
Member
|
@gregchamblin Nope. This one didn't make the cut. |
|
Thank you. I will watch for it in the next update. |
|
🎉 Handy links: |
ghost
mentioned this pull request
|
so how to write a commond to change my terminal title? |
Contributor
In PowerShell: "`e]2;This is the title`a" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Added tab renaming functionality to profiles.json
References
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
Added "tabTitle" : "insert title here" to a profile in the profiles.json