Updated schema with newTabPosition setting#13469
Merged
carlos-zamora merged 2 commits intomicrosoft:mainfrom Jul 14, 2022
Merged
Updated schema with newTabPosition setting#13469carlos-zamora merged 2 commits intomicrosoft:mainfrom
carlos-zamora merged 2 commits intomicrosoft:mainfrom
Conversation
ghost
requested review from
zadjii-msft
approved these changes
Jul 14, 2022
zadjii-msft
added
AutoMerge
|
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Member
|
@zadjii-msft automerge doesn't do anything for doc-only changes haha. I'll merge this manually right now. |
TBBle
reviewed
Jul 23, 2022
Comment on lines
+1980
to
+1981
| } | ||
| }, |
There was a problem hiding this comment.
This appears to be one-too-many closing braces. VSCode is complaining:
Unable to parse content from 'https://raw.githubusercontent.com/microsoft/terminal/2f58711ee6b27064d11dec84010353e144f170f0/doc/cascadia/profiles.schema.json': Parse error at offset 81576.
when used as a $schema value, but does not complain about the previous commit.
Contributor
Author
There was a problem hiding this comment.
I think this happed with the merge from main
ghost
removed
the
ghost
pushed a commit
that referenced
this pull request
Jul 26, 2022
Renames `newTabPosition` strings and enums. Also fixes the schema, noted in #13469 (comment) Closes #13597
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Updates schema with newTabPosition global setting, added in #13421
PR Checklist
newTabPositionMicrosoftDocs/terminal#559Detailed Description of the Pull Request / Additional comments
#13421 got merged, so I'm adding this one