Skip to content

Improve Launch MVVM#13467

Merged
2 commits merged intomainfrom
dev/pabhoj/fix_launch_mvvm
Jul 26, 2022
Merged

Improve Launch MVVM#13467
2 commits merged intomainfrom
dev/pabhoj/fix_launch_mvvm

Conversation

@PankajBhojwani
Copy link
Contributor

@PankajBhojwani PankajBhojwani commented Jul 8, 2022

Summary of the Pull Request

The xaml file no longer directly accesses the settings model object, and the settings model object is no longer exposed on the view model

References

#13377

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated.
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Validation Steps Performed

Still works

PankajBhojwani
PankajBhojwani commented Jul 8, 2022
View reviewed changes
@zadjii-msft zadjii-msft added Product-Terminal The new Windows Terminal. Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Area-SettingsUI Anything specific to the SUI labels Jul 11, 2022
DHowett added a commit that referenced this pull request Jul 12, 2022
@DHowett
PRE-MERGE #13467 Improve Launch MVVM
bb95b1e
DHowett added a commit that referenced this pull request Jul 12, 2022
@DHowett
PRE-MERGE #13467 Improve Launch MVVM
055f899
@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Jul 26, 2022
@ghost
Copy link

ghost commented Jul 26, 2022

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit d9df27f into main Jul 26, 2022
@ghost ghost deleted the dev/pabhoj/fix_launch_mvvm branch July 26, 2022 22:05
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DHowett DHowett DHowett approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

Assignees

No one assigned

Labels

Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Area-SettingsUI Anything specific to the SUI AutoMerge Marked for automatic merge by the bot when requirements are met Product-Terminal The new Windows Terminal.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PankajBhojwani @DHowett @zadjii-msft