Skip to content

Update renderer on SwitchSelectionEndpoint#13435

Merged
1 commit merged intomainfrom
dev/cazamor/bugfix-switchSlnEndpoint
Jul 5, 2022
Merged

Update renderer on SwitchSelectionEndpoint#13435
1 commit merged intomainfrom
dev/cazamor/bugfix-switchSlnEndpoint

Conversation

@carlos-zamora
Copy link
Member

@carlos-zamora carlos-zamora commented Jul 5, 2022

Summary of the Pull Request

In #13370, we should be notifying the renderer that the selection changed. Minor oversight and simple fix.

References

#4993
#13370
Closes #13413

@ghost ghost added Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. labels Jul 5, 2022
@carlos-zamora carlos-zamora mentioned this pull request Jul 5, 2022
Open
11 tasks
@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Jul 5, 2022
@ghost
Copy link

ghost commented Jul 5, 2022

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 7 hours 50 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@DHowett
Copy link
Member

DHowett commented Jul 5, 2022

@msftbot merge this in 5 minutes

@ghost
Copy link

ghost commented Jul 5, 2022

Hello @DHowett!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Tue, 05 Jul 2022 20:19:13 GMT, which is in 5 minutes

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@ghost ghost merged commit 66ecb0b into main Jul 5, 2022
@ghost ghost deleted the dev/cazamor/bugfix-switchSlnEndpoint branch July 5, 2022 20:38
DHowett pushed a commit that referenced this pull request Jul 5, 2022
@carlos-zamora @DHowett
Update renderer on SwitchSelectionEndpoint (#13435)
9e05dcd 
## Summary of the Pull Request
In #13370, we should be notifying the renderer that the selection changed. Minor oversight and simple fix.

## References
#4993
#13370
Closes #13413

(cherry picked from commit 66ecb0b)
Service-Card-Id: 83892665
Service-Version: 1.15
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DHowett DHowett DHowett approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

Assignees

No one assigned

Labels

Area-Settings Issues related to settings and customizability, for console or terminal AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[1.15] switchSelectionEndpoint doesn't work

3 participants

@carlos-zamora @DHowett @zadjii-msft