If we failed to get a default profile, fail the settings load#1343
If we failed to get a default profile, fail the settings load#1343DHowett-MSFT merged 1 commit intomasterfrom
Conversation
This stops the crash in #1318.
|
@zadjii-msft this fixes a symptom. I do not know if it is correct, but it is more correct than it was. What do you think? |
|
It's definitely more correct, though I'm not sure popping the error dialog would be enough to clue people in that the default GUID is null. More correct would be popping the error if the default guid isn't in the list of profiles at all. Even more correct would be to specifically display a message that there was no default profile (though that might be too much for this release). Obviously the most correct solution would be to figure out what causes this zeroing. I don't have a lead on this - @DHowett-MSFT you changed the title of #1318 to say "~30% impact" - do we have more repros? If we can narrow it down today I'd love to fix the real issue, but this is probably good enough if we can't. |
miniksa
left a comment
miniksa
left a comment
There was a problem hiding this comment.
This is OK enough to stop the crash. I agree we should fix the root, but crashy crashy is bad.
4 participants
This stops the crash in #1318.