Add ability to select where new tab will appear#13421
Merged
3 commits merged intomicrosoft:mainfrom Jul 8, 2022
Merged
Conversation
ghost
added
Area-UserInterface
lhecker
approved these changes
Jul 3, 2022
zadjii-msft
approved these changes
Jul 5, 2022
Member
zadjii-msft
left a comment
zadjii-msft
left a comment
There was a problem hiding this comment.
seems pretty legit to me, thanks!
Member
|
If possible, please update the schema and the docs too. |
zadjii-msft
added
the
AutoMerge
|
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Member
|
oh my god I'm so sorry, we should have merged this before #13377, I didn't think it would blow this up with merge conflicts. Sorry about that 😬 |
Contributor
|
Helped fix the conflicts, should be able to auto merge now :) |
ghost
merged commit
This was referenced Jul 8, 2022
carlos-zamora
added a commit
that referenced
this pull request
Jul 14, 2022
## Summary of the Pull Request Updates schema with newTabPosition global setting, added in #13421 ## PR Checklist * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [x] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: MicrosoftDocs/terminal#559 * [x] Schema updated. ## Detailed Description of the Pull Request / Additional comments #13421 got merged, so I'm adding this one Co-authored-by: Carlos Zamora <[email protected]>
DHowett
added
the
Needs-Discussion
zadjii-msft
removed
the
Needs-Discussion
|
🎉 Handy links: |
ghost
mentioned this pull request
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Adds ability to select where new tab will appear: at the end or after currently selected tab.
PR Checklist
Detailed Description of the Pull Request / Additional comments
PR adds setting "NewTabPosition" in global appearances with dropdown list and uses it then creating new tabs. This setting does not affect settings tab position (should it?).
There should also be a documentation update, I'm just waiting to see if this change even acceptable.
Validation Steps Performed