Merged
Conversation
lhecker
approved these changes
Jun 27, 2022
carlos-zamora
requested changes
Jun 27, 2022
| GETSET_BINDABLE_ENUM_SETTING(LaunchMode, Model::LaunchMode, State().Settings().GlobalSettings().LaunchMode); | ||
| GETSET_BINDABLE_ENUM_SETTING(WindowingBehavior, Model::WindowingMode, State().Settings().GlobalSettings().WindowingBehavior); | ||
| WINRT_CALLBACK(PropertyChanged, Windows::UI::Xaml::Data::PropertyChangedEventHandler); | ||
| WINRT_OBSERVABLE_PROPERTY(Editor::LaunchViewModel, ViewModel, _PropertyChangedHandlers, nullptr); |
Member
There was a problem hiding this comment.
If the view model is observable, do we need to make the view inherit from INotifyPropertyChanged?
Contributor
Author
There was a problem hiding this comment.
Good question... It works without it so I think not?
ghost
added
Needs-Author-Feedback
zadjii-msft
added
Area-SettingsUI
zadjii-msft
approved these changes
Jul 7, 2022
Member
zadjii-msft
left a comment
zadjii-msft
left a comment
There was a problem hiding this comment.
Seems pretty straightforward to me
carlos-zamora
approved these changes
Jul 7, 2022
zadjii-msft
added
the
AutoMerge
|
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
6 tasks
ghost
pushed a commit
that referenced
this pull request
Jul 26, 2022
## Summary of the Pull Request The xaml file no longer directly accesses the settings model object, and the settings model object is no longer exposed on the view model ## References #13377 ## PR Checklist * [ ] Closes #xxx * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [ ] Schema updated. * [x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx ## Validation Steps Performed Still works
|
🎉 Handy links: |
3 tasks
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Implements a
LaunchViewModelfor the Launch page in the SUIPR Checklist
Validation Steps Performed
Launch page still works