Skip to content

Introduce toggleBlockSelection action#13219

Merged
1 commit merged intomainfrom
dev/cazamor/ks/toggleBlockSelection
Jun 7, 2022
Merged

Introduce toggleBlockSelection action#13219
1 commit merged intomainfrom
dev/cazamor/ks/toggleBlockSelection

Conversation

@carlos-zamora
Copy link
Member

@carlos-zamora carlos-zamora commented Jun 2, 2022 •
edited
Loading

Summary of the Pull Request

This introduced the toggleBlockSelection action to allow users to create a block selection using only the keyboard. This is not bound to any keys by default, however it is added to the command palette.

References

#4993 - Epic
#5804 - Spec

Validation Steps Performed

  • Mark mode always starts in line selection mode
  • Mouse selections are always in line selection mode by default
  • Can toggle block selection for an existing selection (regardless of how it was created)
  • The selection is copied properly (aka, no rendering issues)

@carlos-zamora
Copy link
Member Author

carlos-zamora commented Jun 2, 2022 •
edited
Loading

Questions for reviewers

  • Should "block selection mode" be a mode that persists? Like, if block selection mode is enabled, should all selections be in block selection by default?
    • personally, I vote no. I think line selection should be the default. Curious if I'm missing anything here though.

Things I should think about (and check)

  • How does this work with screen readers? Is the newly selected text read?
    • EDIT: works well!

@lhecker
Copy link
Member

lhecker commented Jun 3, 2022

Should "block selection mode" be a mode that persists?

I don't think so. It's a seldomly used feature isn't it?

@zadjii-msft zadjii-msft added Needs-Discussion Something that requires a team discussion before we can proceed and removed Needs-Discussion Something that requires a team discussion before we can proceed labels Jun 6, 2022
@zadjii-msft zadjii-msft added the AutoMerge Marked for automatic merge by the bot when requirements are met label Jun 7, 2022
@ghost
Copy link

ghost commented Jun 7, 2022

Hello @zadjii-msft!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit d76c70c into main Jun 7, 2022
@ghost ghost deleted the dev/cazamor/ks/toggleBlockSelection branch June 7, 2022 10:55
@carlos-zamora carlos-zamora mentioned this pull request Jun 26, 2022
Merged
@ghost
Copy link

ghost commented Jul 6, 2022

🎉Windows Terminal Preview v1.15.186 has been released which incorporates this pull request.:tada:

Handy links:

@nguyen-dows nguyen-dows mentioned this pull request May 17, 2023
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lhecker lhecker lhecker approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

Assignees

No one assigned

Labels

AutoMerge Marked for automatic merge by the bot when requirements are met

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@carlos-zamora @lhecker @zadjii-msft