Merged
Conversation
ghost
added
Area-UserInterface
carlos-zamora
approved these changes
May 10, 2022
Member
carlos-zamora
left a comment
carlos-zamora
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks!
lhecker
approved these changes
May 12, 2022
carlos-zamora
added
the
AutoMerge
|
Hello @carlos-zamora! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
DHowett
reviewed
May 17, 2022
|
|
||
| Controls::MenuFlyoutItem findMenuItem; | ||
| { | ||
| // "Split Tab" |
Contributor
Author
There was a problem hiding this comment.
Yeah sorry about that, obviously happened during copy-paste 😅
DHowett
reviewed
May 17, 2022
Member
DHowett
left a comment
DHowett
left a comment
There was a problem hiding this comment.
Thanks for your contribution! :)
DHowett
pushed a commit
that referenced
this pull request
Jun 30, 2022
## Summary of the Pull Request Add `Find` to tab context menu as describe in issue #5633. ## PR Checklist * [x] Closes #5633 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA ## Detailed Description of the Pull Request / Additional comments Just wanted to solve `Easy Starter` issue, so any corrections/suggestions welcome. There's a couple of points I'm not sure of * Placement of item within menu, currently it's at the end before close tab block. * Should it be named longer, something like `Find in Tab` of just `Find` is fine? * The workaround for focus similar to tab rename is a bit annoying, especially because it required adding a method to `TermControl` but without it find window obviously opens without focus which is bad. ## Validation Steps Performed Open menu, press menu item try to find things via opened find dialog. (cherry picked from commit b851b0d) Service-Card-Id: 83524184 Service-Version: 1.14
|
🎉 Handy links: |
ghost
mentioned this pull request
|
🎉 Handy links: |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Add
Findto tab context menu as describe in issue #5633.PR Checklist
Detailed Description of the Pull Request / Additional comments
Just wanted to solve
Easy Starterissue, so any corrections/suggestions welcome. There's a couple of points I'm not sure ofFind in Tabof justFindis fine?TermControlbut without it find window obviously opens without focus which is bad.Validation Steps Performed
Open menu, press menu item try to find things via opened find dialog.