Add a setting for the unfocused tabRow background color#13049
Merged
73 commits merged intomainfrom Jul 7, 2022
Merged
Conversation
https://stackoverflow.com/questions/64694722/changing-themeresources-dynamically-in-uwp That post looked SUPER promising. Problem is though, I CANNOT for the life of me get that to work. Like, I can't get anything to `{Binding Brush, Mode=TwoWay, Source={StaticResource TerminalBackground}}` to the `TerminalBackground` thing I made there. I thought that was so clever. I wanted an easy way to just change the value of a resource and have it update the Titlebar, but since the Titlebar isn't a child of the TerminalPage, and this binding thing didn't work, I think I'm at a dead end.
…dev/migrie/fhl/theming-2022-prototype
…ses are NOT optional
…to be sub-properties of the Theme
Member
Author
|
|
…f/unfocused-tabRow-bg
…f/unfocused-tabRow-bg
lhecker
approved these changes
May 26, 2022
ghost
requested review from
carlos-zamora
approved these changes
Jul 7, 2022
Member
carlos-zamora
left a comment
carlos-zamora
left a comment
There was a problem hiding this comment.
You weren't kidding, hiding the whitespace makes this pretty trivial haha.
Comment on lines
+107
to
+110
| // NOTE: There is no canonical way to get the unfocused ACCENT titlebar | ||
| // color in Windows. Edge uses it's own heuristic, and in Windows 11, | ||
| // much of this logic is rapidly changing. We're not gonna mess with | ||
| // that, since it seems there's no good way to reverse engineer that. |
Member
There was a problem hiding this comment.
Maybe we should // TODO GH# this to track it?
Member
Author
There was a problem hiding this comment.
All the recommendations I got officially were basically "don't even try this", so I'm inclined to just say "nah". Filing an issue would result in it just being wont-fix'ed immediately (IMO)
DHowett
approved these changes
Jul 7, 2022
zadjii-msft
added
the
AutoMerge
|
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
🎉 Handy links: |
ghost
mentioned this pull request
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
tabRow.unfocusedBackgroundto the theme properties.When provided, the window will use this ThemeColor as the color of the tab row when the window is inactive.
When omitted, the window will fall back to the default tab row color,
{"key": "TabViewBackground"}from our App.xaml.This actually helped validate #12992 quite a bit. I found a bunch of bugs concerning null colors, null objects. Json parsing is hard 😛