Stop the viewport being moved when in the alt buffer#13039
Merged
1 commit merged intomicrosoft:mainfrom May 5, 2022
Merged
Conversation
ghost
added
Area-TerminalControl
Collaborator
Author
|
I'm sorry for breaking it in the first place! |
zadjii-msft
approved these changes
May 5, 2022
zadjii-msft
added
the
AutoMerge
|
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
|
🎉 Handy links: |
ghost
mentioned this pull request
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
When
TerminalDispatchwas merged withAdaptDispatchin PR #13024,that broke the Terminal's
EraseAlloperation in the alt buffer. Theproblem was that the
EraseAllimplementation makes a call toSetViewportPositionwhich wasn't taking the alt buffer into account,and thus modified the main viewport instead.
This PR corrects that mistake. If we're in the alt buffer, the
SetViewportPositionmethod now does nothing, since the alt bufferviewport should always be at 0,0.
References
This was a regression introduced in PR #13024.
PR Checklist
Validation Steps Performed
I've confirmed that the test case reported in issue #13038 is no longer
failing. I've also made sure the
ED 2andED 3sequences are stillworking correctly in the main buffer.