Merged
Conversation
* use `FontFamily="{ThemeResource SymbolThemeFontFamily}"` where possible, in XAML
* use `FontFamily{ L"Segoe Fluent Icons, Segoe MDL2 Assets" }` in codebehind
Basically just a simple string replace.
* [x] This was a bullet point in #11353
* [x] Confirmed manually on my win10 PC
* see also #12438
Screenshots below.
zadjii-msft
added
Issue-Bug
17 tasks
ghost
added
Issue-Task
Member
Author
|
|
DHowett
approved these changes
Feb 11, 2022
| @@ -124,7 +124,7 @@ namespace winrt::Microsoft::Terminal::Settings::Model::implementation | |||
| const bool isMDL2Icon = ch >= L'\uE700' && ch <= L'\uF8FF'; | |||
| if (isMDL2Icon) | |||
Member
There was a problem hiding this comment.
does the available range change for the new iconfont?
ghost
requested review from
PankajBhojwani,
carlos-zamora,
leonMSFT,
lhecker and
miniksa
PankajBhojwani
approved these changes
Feb 11, 2022
carlos-zamora
approved these changes
Feb 11, 2022
lhecker
approved these changes
Feb 11, 2022
Member
|
holy sh*t, that's everyone |
Member
|
@msftbot merge this in 1 minute |
ghost
added
the
AutoMerge
|
Hello @DHowett! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
DHowett
pushed a commit
that referenced
this pull request
Feb 16, 2022
* use `FontFamily="{ThemeResource SymbolThemeFontFamily}"` where possible, in XAML
* use `FontFamily{ L"Segoe Fluent Icons, Segoe MDL2 Assets" }` in codebehind
Basically just a simple string replace.
* [x] This was a bullet point in #11353
* [x] Confirmed manually on my win10 PC
* see also #12438
Actually, this is the last bullet in #11353, so I'm gonna say closes #11353.
Screenshots below.
(cherry picked from commit 0a15643)
zadjii-msft
added a commit
that referenced
this pull request
Mar 3, 2022
* use `FontFamily="{ThemeResource SymbolThemeFontFamily}"` where possible, in XAML
* use `FontFamily{ L"Segoe Fluent Icons, Segoe MDL2 Assets" }` in codebehind
Basically just a simple string replace.
* [x] This was a bullet point in #11353
* [x] Confirmed manually on my win10 PC
* see also #12438
Actually, this is the last bullet in #11353, so I'm gonna say closes #11353.
Screenshots below.
|
🎉 Handy links: |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FontFamily="{ThemeResource SymbolThemeFontFamily}"where possible, in XAMLFontFamily{ L"Segoe Fluent Icons, Segoe MDL2 Assets" }in codebehindBasically just a simple string replace.
Actually, this is the last bullet in #11353, so I'm gonna say closes #11353.
Screenshots below.