Manually set the colors of the TabViewBackground#12460
Merged
3 commits merged intomainfrom Feb 15, 2022
Merged
Conversation
ghost
added
Area-TerminalControl
Member
Ha. |
miniksa
approved these changes
Feb 10, 2022
| if (_settings.GlobalSettings().UseAcrylicInTabRow()) | ||
| { | ||
| const auto res = Application::Current().Resources(); | ||
|
|
carlos-zamora
approved these changes
Feb 11, 2022
Member
Author
|
For clarity of intent, I'm gonna merge this one now and update the values in a separate PR. |
zadjii-msft
added
the
AutoMerge
|
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
DHowett
pushed a commit
that referenced
this pull request
Feb 16, 2022
This has been a saga. Basically, any resources in `App.xaml` aren't going to be able to reference other theme-aware resources. We can't change the theme of the app at runtime, only elements within the app. So we can't use `ApplicationPageBackgroundThemeBrush` in app.xaml, because it will ALWAYS be evaluated as the OS theme version of that brush. * regressed in #12326 * See also #10864 * #3917 CANNOT be fixed in the same way. We're lucky here that the TabView uses a `{ThemeResource TabViewBackground}` in markup to set the bg. We're not similarly lucky with the Pane one. * [x] closes #12356 * [x] Tested manually. You can confirm, my eyes are bleeding from the OS-wide light mode (cherry picked from commit 5ba0d61)
Closed
zadjii-msft
added a commit
that referenced
this pull request
Mar 3, 2022
This has been a saga. Basically, any resources in `App.xaml` aren't going to be able to reference other theme-aware resources. We can't change the theme of the app at runtime, only elements within the app. So we can't use `ApplicationPageBackgroundThemeBrush` in app.xaml, because it will ALWAYS be evaluated as the OS theme version of that brush. * regressed in #12326 * See also #10864 * #3917 CANNOT be fixed in the same way. We're lucky here that the TabView uses a `{ThemeResource TabViewBackground}` in markup to set the bg. We're not similarly lucky with the Pane one. * [x] closes #12356 * [x] Tested manually. You can confirm, my eyes are bleeding from the OS-wide light mode
|
🎉 Handy links: |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been a saga.
Basically, any resources in
App.xamlaren't going to be able to reference other theme-aware resources. We can't change the theme of the app at runtime, only elements within the app. So we can't useApplicationPageBackgroundThemeBrushin app.xaml, because it will ALWAYS be evaluated as the OS theme version of that brush.requestedTheme, follows system app mode #3917 CANNOT be fixed in the same way. We're lucky here that the TabView uses a{ThemeResource TabViewBackground}in markup to set the bg. We're not similarly lucky with the Pane one.