Fix the add/delete unfocused appearance buttons#12451
Conversation
|
idly: Should it just be "Add" and "Delete"? The whole string there seems redundant with the title.... |
zadjii-msft
added
Area-SettingsUI
Yeah you're right, fixed! |
|
The only nit I'd have is that the baseline of the button appears to be sitting on the baseline of the text, when I think it should actually be centered vertically on the entire row of text. (That is, the button is slightly too high up and should be slightly lower... including the descender area as part of its centering calculation and not only the ascender area above the baseline.) |
|
Well I look closer and it is sort of below the baseline where the descenders are... but it still looks awfully "tall" over the top of the text beside it...
|
|
(The "+" and the "Add" also don't seem to have the same vertical centerline either...)
|
Is this just because the text right beside it are non-ascenders? When I look at the space between the red/green lines below/above the 'd' or the 'f' (the ascender characters) the spacing seems fine to me...
Adjusted the margin here to make the "+" more center - here's the new look |
Yeah could be. I might just be taking crazy pills.
Looks better to me, thank you. |
zadjii-msft
added
the
AutoMerge
|
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
|
@PankajBhojwani how does this look when the window is very small? |
|
(and what if the translation for Add is very long) |
There seems to be enough space for approximately 2x the english 'Delete' size and 3x the english 'Add' size. We could add a maxwidth and add a tooltip to the button for even longer translations? |
|
thanks! |
## Summary of the Pull Request The add/delete unfocused appearance buttons now have text on them and are closed to the `Unfocused appearance` header ## References #11353 ## PR Checklist * [ ] Closes #xxx * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [ ] Schema updated. * [x] I work here ## Validation Steps Performed <img width="548" alt="add" src="https://user-images.githubusercontent.com/26824113/153463971-de14a68b-5ed9-4768-80f8-2a5a5a21bc9f.png"> <img width="557" alt="delete" src="https://user-images.githubusercontent.com/26824113/153463993-9a7413d4-d895-4813-a6ff-1b157f1e72f4.png">
## Summary of the Pull Request The add/delete unfocused appearance buttons now have text on them and are closed to the `Unfocused appearance` header ## References #11353 ## PR Checklist * [ ] Closes #xxx * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [ ] Schema updated. * [x] I work here ## Validation Steps Performed <img width="548" alt="add" src="https://user-images.githubusercontent.com/26824113/153463971-de14a68b-5ed9-4768-80f8-2a5a5a21bc9f.png"> <img width="557" alt="delete" src="https://user-images.githubusercontent.com/26824113/153463993-9a7413d4-d895-4813-a6ff-1b157f1e72f4.png"> (cherry picked from commit c0083ef)
4 participants
Summary of the Pull Request
The add/delete unfocused appearance buttons now have text on them and are closed to the
Unfocused appearanceheaderReferences
#11353
PR Checklist
Validation Steps Performed