Conversation
|
I decided to add tooltips to all the other nav view items (Startup, Interaction, etc) since we're already adding them for the profile items. Currently those tooltips' text is exactly the same as the nav view item text, would we rather add more of a description to each of them (so kinda like how the 'open json file' button has a bit of a descriptor)? |
|
I am okay with the tooltips just saying the same thing as the title. I am also surprised that they do not automatically do so when the NavigationView is in collapsed state! |
Weirdly, when I (on 1.13.10333) have the nav view collapsed, everything has tooltips for me. Only when I expand it do the profiles not have tooltips. w e i r d |
zadjii-msft
added
the
AutoMerge
|
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
## Summary of the Pull Request Profiles with long names were having their titles cut off in the navigation view sidebar. This change adds tooltips to all nav view items so the full names can still be read. ## References #11353 ## PR Checklist * [ ] Closes #xxx * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [ ] Schema updated. * [x[ I work here ## Validation Steps Performed <img width="261" alt="sidebartooltip" src="https://user-images.githubusercontent.com/26824113/153270004-02ec3ca7-8787-41be-a4ee-c60efa8cc5e6.png"> <img width="341" alt="sidebartooltip2" src="https://user-images.githubusercontent.com/26824113/153270033-263069f6-75ff-4215-9c83-e0a946ce9616.png"> (cherry picked from commit 19a5eb2)
## Summary of the Pull Request Profiles with long names were having their titles cut off in the navigation view sidebar. This change adds tooltips to all nav view items so the full names can still be read. ## References #11353 ## PR Checklist * [ ] Closes #xxx * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [ ] Schema updated. * [x[ I work here ## Validation Steps Performed <img width="261" alt="sidebartooltip" src="https://user-images.githubusercontent.com/26824113/153270004-02ec3ca7-8787-41be-a4ee-c60efa8cc5e6.png"> <img width="341" alt="sidebartooltip2" src="https://user-images.githubusercontent.com/26824113/153270033-263069f6-75ff-4215-9c83-e0a946ce9616.png"> (cherry picked from commit 19a5eb2)
|
🎉 Handy links: |
|
🎉 Handy links: |
4 participants
Summary of the Pull Request
Profiles with long names were having their titles cut off in the navigation view sidebar. This change adds tooltips to all nav view items so the full names can still be read.
References
#11353
PR Checklist
Validation Steps Performed