Fix focus box around color schemes combo box#12439
Merged
Conversation
ghost
added
Area-SettingsUI
zadjii-msft
approved these changes
Feb 8, 2022
DHowett
reviewed
Feb 8, 2022
|
|
||
| <!-- Select Color and Add New Button --> | ||
| <StackPanel Orientation="Horizontal"> | ||
| <StackPanel Margin="0,5,0,0" |
Member
There was a problem hiding this comment.
this also moves the whole box down -- OK?
Contributor
Author
There was a problem hiding this comment.
Yes, very slightly! The page doesn't look any different from the other pages though (and it is going to be overhauled very soon anyway)
DHowett
approved these changes
Feb 8, 2022
|
🎉 Handy links: |
ghost
mentioned this pull request
zadjii-msft
pushed a commit
that referenced
this pull request
Mar 3, 2022
The focus box around the color schemes combo box was getting cut off, this change adds a small margin to the stackpanel to allow space for the focus box ## PR Checklist * [x] Closes #12328
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
The focus box around the color schemes combo box was getting cut off, this change adds a small margin to the stackpanel to allow space for the focus box
PR Checklist
Color schemesnot showing top border #12328Validation Steps Performed