Skip to content

Fix browse buttons getting cut off when the window is too narrow#12435

Merged
DHowett merged 2 commits intomainfrom
dev/pabhoj/text_box_fix
Feb 8, 2022
Merged

Fix browse buttons getting cut off when the window is too narrow#12435
DHowett merged 2 commits intomainfrom
dev/pabhoj/text_box_fix

Conversation

@PankajBhojwani
Copy link
Contributor

Summary of the Pull Request

With the recent change to allow text boxes to be bigger, the Browse button that some of them have was getting cut off when the window was too narrow. This change puts the Browse button below the text box instead of next to it to prevent this issue.

PR Checklist

Validation Steps Performed

commandlinenarrow

commandlinewide

startingDir

@ghost ghost added Area-SettingsUI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Feb 8, 2022
@PankajBhojwani
Copy link
Contributor Author

Not sure why the format check is failing... Invoke-CodeFormat isn't making any changes

@DHowett DHowett merged commit 02135ed into main Feb 8, 2022
@DHowett DHowett deleted the dev/pabhoj/text_box_fix branch February 8, 2022 23:22
zadjii-msft pushed a commit that referenced this pull request Mar 3, 2022
)

With the recent change to allow text boxes to be bigger, the `Browse` button that some of them have was getting cut off when the window was too narrow. This change puts the `Browse` button below the text box instead of next to it to prevent this issue.

## PR Checklist
* [x] Closes #12335
DHowett pushed a commit that referenced this pull request Mar 28, 2022
)

With the recent change to allow text boxes to be bigger, the `Browse` button that some of them have was getting cut off when the window was too narrow. This change puts the `Browse` button below the text box instead of next to it to prevent this issue.

## PR Checklist
* [x] Closes #12335

(cherry picked from commit 02135ed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-SettingsUI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[SUI] A long commandline causes the 'Browse' button to get cut off if the window is too narrow

3 participants