[Command Palette] Announce if suggestions were found to screen readers#12266
[Command Palette] Announce if suggestions were found to screen readers#122661 commit merged intomainfrom
Conversation
|
THANKS! |
DHowett
added
the
AutoMerge
|
Hello @DHowett! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 7 hours 42 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
@msftbot merge this in 5 minutes |
|
Hello @carlos-zamora! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
ghost
merged commit #12266) ## Summary of the Pull Request Expands on #9582. If the command palette finds results, the screen reader says "Suggestions available". Makes the scenario mentioned in #7907 work. This is sufficient for various reasons: 1. According to the bug report, saying that suggestions are available is sufficient > Screen reader should provide the results info on searching commands like 10 results found or suggestions available when there are any search results (Source: #7907) 2. This is common practice. Settings app and XAML Controls Gallery do this for their search box. Also, the user should be able to know how many results were found by tabbing/selecting a result item. When this is done, the screen reader will use `SizeOfSet` and `PositionInSet` to announce how many results were found and which one we're currently on. ## Validation Steps Performed Verified this behavior using Narrator. Verified it matches the behavior of the Settings app and the XAML Controls Gallery. (cherry picked from commit 1e47d7a)
Basically, this is the same as #12266, but for the `SearchBoxControl`. Trickily, the ControlCore is the one that knows if there were search results, but the TermControl has to be the one to announce it. * [x] Will take care of #11973 once a11y team confirms * [x] Tested manually with Narrator * [x] Resolves a part of #6319, which I'm repurposing just to displaying the number of results in general. * See also #3920
Basically, this is the same as #12266, but for the `SearchBoxControl`. Trickily, the ControlCore is the one that knows if there were search results, but the TermControl has to be the one to announce it. * [x] Will take care of #11973 once a11y team confirms * [x] Tested manually with Narrator * [x] Resolves a part of #6319, which I'm repurposing just to displaying the number of results in general. * See also #3920 (cherry picked from commit fbe0416)
|
🎉 Handy links: |
|
🎉 Handy links: |
3 participants
Summary of the Pull Request
Expands on #9582. If the command palette finds results, the screen reader says "Suggestions available".
Makes the scenario mentioned in #7907 work.
This is sufficient for various reasons:
Also, the user should be able to know how many results were found by tabbing/selecting a result item. When this is done, the screen reader will use
SizeOfSetandPositionInSetto announce how many results were found and which one we're currently on.Validation Steps Performed
Verified this behavior using Narrator.
Verified it matches the behavior of the Settings app and the XAML Controls Gallery.