Disable being able to set the automatic adjustment of indistinguishable text#12160
Merged
5 commits merged intomainfrom Jan 18, 2022
Merged
Disable being able to set the automatic adjustment of indistinguishable text#121605 commits merged intomainfrom
5 commits merged intomainfrom
Conversation
carlos-zamora
approved these changes
Jan 13, 2022
Member
carlos-zamora
left a comment
carlos-zamora
left a comment
There was a problem hiding this comment.
- update the schema plz
- update the docs plz
- Curious: why not keep this feature in preview, but with it being disabled by default? I get there's a bug, but if the behavior is opt-in, wouldn't that be acceptable for a preview-level feature?
Collaborator
|
Sorry, I think my PR #12127 has messed things up a bit for you here. The color adjustment code has now been moved into a new |
lhecker
approved these changes
Jan 14, 2022
PankajBhojwani
changed the title
Member
|
Was going to merge, but want to see @PankajBhojwani address @carlos-zamora's questions. |
DHowett
changed the title
DHowett
changed the title
zadjii-msft
approved these changes
Jan 18, 2022
zadjii-msft
added
the
AutoMerge
|
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
Member
|
|
Contributor
Author
|
My bad, this slipped my mind while trying to get #12144 ready for the bug bash. Will file a separate PR to make this a preview-only feature that's disabled by default as per @carlos-zamora's suggestion EDIT: after team discussion, we are going to make this a dev-only setting for now |
|
🎉 Handy links: |
6 tasks
ghost
pushed a commit
that referenced
this pull request
Feb 9, 2022
…or Dev builds (#12444) ## Summary of the Pull Request Followup from our discussion during team sync, the 'automatic adjustment of indistinguishable text' setting is going to be enabled for dev builds only. ## References #12160 ## PR Checklist * [ ] Closes #xxx * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [ ] Schema updated. * [x] I work here ## Validation Steps Performed Setting appears on dev build and the feature works
5 tasks
ghost
pushed a commit
that referenced
this pull request
Jul 14, 2022
…13343) ## Summary of the Pull Request Re-enable the setting to adjust indistinguishable text, with some changes: - We now pre-calculate the nudged values for 'default bright foreground' as well - When a color table entry is manually set (i.e. via VT sequences) we re-calculate the nudged values ## References #11095 #12160 ## PR Checklist * [x] Closes #11917 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [ ] Schema updated. ## Validation Steps Performed Indistinguishable text gets adjusted again
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Disables the automatic adjustment of indistinguishable text (added in #11095) because of the concerns brought up in #11917. Also, the setting is hidden in the SUI for as long as this feature remains disabled.
PR Checklist