Add a BreadcrumbBar to the SUI by PankajBhojwani · Pull Request #12144 · microsoft/terminal

PankajBhojwani · 2022-01-12T00:07:54Z

Summary of the Pull Request

Note: This PR targets #11720

Replaces our old pivot-style settings UI with a breadcrumb bar style, as per the windows 11 style guidelines. This required splitting Profiles.xaml into 3 separate files, Profiles_Base.xaml for general settings, Profiles_Appearance.xaml for appearance settings, Profiles_Advanced.xaml for advanced settings

The header in the navigation view is now a BreadcrumbBar, which can be used to navigate back to Profiles_Base after moving into the advanced or appearance page (see GIF below)

PR Checklist

Closes #xxx
CLA signed. If not, go over here and sign the CLA
Tests added/passed
Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
Schema updated.
I work here

Validation Steps Performed

src/cascadia/TerminalSettingsEditor/MainPage.cpp

src/cascadia/TerminalSettingsEditor/Profiles_Base.xaml

zadjii-msft · 2022-01-12T12:42:24Z

#11877 looks like it needs to get merged into #11720 (and this pr too)

DHowett · 2022-01-13T00:10:48Z

this looks really good btw

lhecker · 2022-01-17T17:15:41Z

While the UX of using expanders is questionable, I love how closely it resembles the settings app. Nice! 💖

Regarding early criticism... I feel like it would look better if the breadcrumb bar was aligned with the top margin like so:

PankajBhojwani · 2022-01-18T17:50:14Z

I feel like it would look better if the breadcrumb bar was aligned with the top margin like so:

Requires some funky negative margins on the header and the grid but yeah I agree it looks better, changed it!

PankajBhojwani · 2022-01-20T19:51:05Z

We discovered a bunch of bugs/issues during the bug bash - those that are relevant to this PR have been fixed here, the others will be fixed either in the base PR or in other PRs that target the base one. So this PR is ready for review now!

zadjii-msft · 2022-01-21T14:23:21Z

Reviewing now. Immediate notes before I forget:

Click&drag on these buttons does something... weird:
We should make sure to do a High Contrast pass for bugs

These are nits. The HC one should be done in 1.13, but I won't block these PRs over that. The drag one is probably a P3 that can wait.

zadjii-msft

Okay I'm at 22/30, but I want to be sure about these ProfileViewModel things before I go through the last few with the same comment a bunch of times

src/cascadia/TerminalSettingsEditor/Profiles_Advanced.cpp

PankajBhojwani · 2022-01-21T17:49:25Z

Click&drag on these buttons does something... weird

You could repro that without dragging! That's the issue where going Appearance->back to profile via breadcrumb->Appearance again does nothing (same with Advanced). Its fixed now though (I think you're on the bug bash branch)

ghost · 2022-01-28T18:45:21Z

Hello @zadjii-msft!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

**Note: This PR targets #11720** Replaces our old pivot-style settings UI with a breadcrumb bar style, as per the windows 11 style guidelines. This required splitting `Profiles.xaml` into 3 separate files, `Profiles_Base.xaml` for general settings, `Profiles_Appearance.xaml` for appearance settings, `Profiles_Advanced.xaml` for advanced settings The header in the navigation view is now a [BreadcrumbBar](https://docs.microsoft.com/en-us/windows/apps/design/controls/breadcrumbbar), which can be used to navigate back to `Profiles_Base` after moving into the advanced or appearance page (see GIF below)  * [ ] Closes #xxx * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [ ] Schema updated. * [x] I work here ![breadcrumb](https://user-images.githubusercontent.com/26824113/150410517-2232811e-4f5b-4732-9a0d-569cc94093b3.gif)

PankajBhojwani added 6 commits November 2, 2021 10:59

testing

0b58355

got 2 styles that kinda work I guess

ba4faec

apparently this is the old expander

f3fd857

just use muxc:expander

13bbcbf

remove remnants of previous implementation, format

81d0c5c

carlos comments

61ae0a1

PankajBhojwani commented Jan 12, 2022

View reviewed changes

src/cascadia/TerminalSettingsEditor/MainPage.cpp Show resolved Hide resolved

PankajBhojwani commented Jan 12, 2022

View reviewed changes

src/cascadia/TerminalSettingsEditor/MainPage.cpp Outdated Show resolved Hide resolved

PankajBhojwani commented Jan 12, 2022

View reviewed changes

src/cascadia/TerminalSettingsEditor/MainPage.cpp Outdated Show resolved Hide resolved

PankajBhojwani commented Jan 12, 2022

View reviewed changes

src/cascadia/TerminalSettingsEditor/Profiles_Base.xaml Show resolved Hide resolved

PankajBhojwani added 2 commits January 12, 2022 10:29

merge main

e6dffda

format

de8a869

PankajBhojwani force-pushed the dev/pabhoj/SUI_breadcrumb branch from c45cb11 to f8b7db9 Compare January 12, 2022 22:55

PankajBhojwani mentioned this pull request Jan 18, 2022

Disable being able to set the automatic adjustment of indistinguishable text #12160

Merged

6 tasks

PankajBhojwani marked this pull request as ready for review January 20, 2022 17:46

PankajBhojwani mentioned this pull request Jan 20, 2022

Update our SUI to follow win 11 guidelines #11720

Merged

9 tasks

PankajBhojwani added 2 commits January 20, 2022 10:28

left align actions

26652fe

add more margin for scroll bar

cefa906

PankajBhojwani added 2 commits January 20, 2022 14:50

vertically center settings without help text

79daeed

fix long text messing up setting container

103d661

zadjii-msft requested changes Jan 21, 2022

View reviewed changes

src/cascadia/TerminalSettingsEditor/Profiles_Advanced.cpp Outdated Show resolved Hide resolved

src/cascadia/TerminalSettingsEditor/Profiles_Advanced.cpp Outdated Show resolved Hide resolved

ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jan 21, 2022

ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jan 21, 2022

PankajBhojwani added 17 commits January 27, 2022 11:17

rebase after merge main in base branch

90b8366

breadcrumb as iinspectable instead

2da46bb

helpers in main page

5680f48

_Navigate now takes an optional label parameter for sub pages

f776853

comment

cff990f

use enums instead of strings

c02fb81

macro

15197ff

align bcrumb bar differently

c2d0c21

add chevron to buttons

d5881e4

fix profile pages margins

7e90bf1

margin around font face box

579e07d

Additional settings header

3e53ef6

fix breadcrumb label

db2208f

remove things that are already in PVM

c42178d

conflict

54eda74

format

9f672a7

update to new toggle switch

20d34b5

PankajBhojwani force-pushed the dev/pabhoj/SUI_breadcrumb branch from 14f465e to 20d34b5 Compare January 27, 2022 19:52

Base automatically changed from dev/pabhoj/SUI_11 to main January 28, 2022 00:43

PankajBhojwani added 2 commits January 27, 2022 17:27

conflict

5d28a35

format

685a772

zadjii-msft added this to the Terminal v1.13 milestone Jan 28, 2022

zadjii-msft added the AutoMerge Marked for automatic merge by the bot when requirements are met label Jan 28, 2022

ghost merged commit 21d30b1 into main Jan 28, 2022

ghost deleted the dev/pabhoj/SUI_breadcrumb branch January 28, 2022 18:46

mailinglists35 mentioned this pull request Feb 6, 2022

Update changed tab colors so I can no longer figure out which one is active 🤬 #12398

Closed

zadjii-msft mentioned this pull request Feb 7, 2022

UI nits from WinUI Controlsv2 #12400

Open

12 tasks

zadjii-msft mentioned this pull request Mar 15, 2022

Merge the Windows 11 styles into 1.12 #12696

Merged

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a BreadcrumbBar to the SUI#12144

Add a BreadcrumbBar to the SUI#12144
43 commits merged intomainfrom
dev/pabhoj/SUI_breadcrumb

PankajBhojwani commented Jan 12, 2022 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zadjii-msft commented Jan 12, 2022

Uh oh!

DHowett commented Jan 13, 2022

Uh oh!

lhecker commented Jan 17, 2022

Uh oh!

PankajBhojwani commented Jan 18, 2022

Uh oh!

PankajBhojwani commented Jan 20, 2022

Uh oh!

zadjii-msft commented Jan 21, 2022

Uh oh!

zadjii-msft left a comment

Uh oh!

Uh oh!

Uh oh!

PankajBhojwani commented Jan 21, 2022

Uh oh!

ghost commented Jan 28, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

PankajBhojwani commented Jan 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of the Pull Request

PR Checklist

Validation Steps Performed

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zadjii-msft commented Jan 12, 2022

Uh oh!

DHowett commented Jan 13, 2022

Uh oh!

lhecker commented Jan 17, 2022

Uh oh!

PankajBhojwani commented Jan 18, 2022

Uh oh!

PankajBhojwani commented Jan 20, 2022

Uh oh!

zadjii-msft commented Jan 21, 2022

Uh oh!

zadjii-msft left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

PankajBhojwani commented Jan 21, 2022

Uh oh!

ghost commented Jan 28, 2022

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

PankajBhojwani commented Jan 12, 2022 •

edited

Loading

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.