Conversation
Revert "Fix environment block creation (#7401)" This reverts commit 7886f16. (cherry picked from commit e46ba65) Revert "Always create a new environment block before we spawn a process (#7243)" This reverts commit 849243a. References #7418 (cherry picked from commit 4204d25) (cherry picked from commit f8e8572) (cherry picked from commit cb4c4f7) (cherry picked from commit afb0cac) (cherry picked from commit b25dc74) (cherry picked from commit 5f7c66b)
ghost
added
Area-TerminalConnection
|
FWIW perhaps reverting this is not the correct thing to do -- maybe the only part that needs to be undone is very specifically https://github.com/microsoft/terminal/pull/12140/files#diff-f0e3698039059eb99ef5a8957cd06df3534b969d496aa40210fbe669b83ca4dbL103. @miniksa - is any of the code I'm deleting with this revert going to be useful for you in your environment work? |
|
FWIW I'm cool with the revert as is. If we ever need this again, we know where to find it |
carlos-zamora
left a comment
carlos-zamora
left a comment
There was a problem hiding this comment.
(same sentiment as what zadji said haha)
zadjii-msft
added
the
AutoMerge
|
Hello @zadjii-msft! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 6 hours 43 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
|
🎉 Handy links: |
ghost
mentioned this pull request
3 participants
Revert "Fix environment block creation (#7401)"
This reverts commit 7886f16.
(cherry picked from commit e46ba65)
Revert "Always create a new environment block before we spawn a process (#7243)"
This reverts commit 849243a.
(cherry picked from commit 4204d25)
(cherry picked from commit f8e8572)
(cherry picked from commit cb4c4f7)
(cherry picked from commit afb0cac)
(cherry picked from commit b25dc74)
(cherry picked from commit 5f7c66b)
Fixes #7418