Skip to content

Pass additional parameters when making PGO package#12131

Merged
miniksa merged 2 commits intomainfrom
dev/miniksa/pgo_instrument_fix
Jan 11, 2022
Merged

Pass additional parameters when making PGO package#12131
miniksa merged 2 commits intomainfrom
dev/miniksa/pgo_instrument_fix

Conversation

@miniksa
Copy link
Member

@miniksa miniksa commented Jan 10, 2022

Pass additional parameters when making PGO package

@miniksa miniksa added Area-Performance Performance-related issue Issue-Bug It either shouldn't be doing this or needs an investigation. Area-Build Issues pertaining to the build system, CI, infrastructure, meta Product-Terminal The new Windows Terminal. labels Jan 10, 2022
@miniksa
Copy link
Member Author

miniksa commented Jan 10, 2022

Running a test build with this now.

Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@miniksa miniksa changed the title Pass instrument parameter when making PGO package Pass additional parameters when making PGO package Jan 10, 2022
@miniksa
Copy link
Member Author

miniksa commented Jan 11, 2022

k its fine. it's just the y2k22 bug now that I'm waiting on the upstream team to fix.

@miniksa miniksa merged commit d0c4cf7 into main Jan 11, 2022
@miniksa miniksa deleted the dev/miniksa/pgo_instrument_fix branch January 11, 2022 17:55
DHowett pushed a commit that referenced this pull request Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Build Issues pertaining to the build system, CI, infrastructure, meta Area-Performance Performance-related issue Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants