Skip to content

Bump the minversion of the Terminal#12129

Merged
1 commit merged intomainfrom
dev/migrie/b/11371-bump-min-version
Jan 11, 2022
Merged

Bump the minversion of the Terminal#12129
1 commit merged intomainfrom
dev/migrie/b/11371-bump-min-version

Conversation

@zadjii-msft
Copy link
Member

@zadjii-msft zadjii-msft commented Jan 10, 2022

As discussed. We're not going to be able to consistently get bugfixes below Vb anymore, so let's leave that as the MinVersion, so we can start adding features that depend on those bugfixes.

@ghost ghost added Issue-Question For questions or discussion Product-Meta The product is the management of the products. labels Jan 10, 2022
carlos-zamora
carlos-zamora approved these changes Jan 10, 2022
View reviewed changes
Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to...

When we do this, we should make sure to revert the changes that fixed 11285

I guess this should be a separate code-health issue? 🤷

@zadjii-msft
Copy link
Member Author

zadjii-msft commented Jan 10, 2022

When we do this, we should make sure to revert the changes that fixed 11285

I guess this should be a separate code-health issue? 🤷

Meh, we're in an annoying place with that. We're still waiting to get the transparency fix backported, but the person who needs to help us with that is still on leave. So we can't really remove that hack until that's in, but we also plan on bumping the version in this release regardless.

Lemme ping that thread again. I never got a servicing ticket number to follow, so it might have already been done ¯\_(ツ)_/¯

@miniksa
Copy link
Member

miniksa commented Jan 10, 2022

Please check that the UIA tests still run in the lab after this change.

miniksa
miniksa requested changes Jan 10, 2022
View reviewed changes
Copy link
Member

@miniksa miniksa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double check UIA test run in lab first please.

@ghost ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jan 10, 2022
@zadjii-msft
Copy link
Member Author

zadjii-msft commented Jan 10, 2022

Double check UIA test run in lab first please.

https://dev.azure.com/microsoft/Dart/_build/results?buildId=43624857&view=logs&j=9235745c-fc54-53ad-475a-db0cef308774&t=620c6769-1e8e-5797-d1c8-312bc84864fc

@ghost ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jan 10, 2022
miniksa
miniksa approved these changes Jan 10, 2022
View reviewed changes
Copy link
Member

@miniksa miniksa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Task failed successfully.

@miniksa
Copy link
Member

miniksa commented Jan 10, 2022

(aka it's #12131 you're seeing, not a problem from this change)

@zadjii-msft zadjii-msft added the AutoMerge Marked for automatic merge by the bot when requirements are met label Jan 11, 2022
@ghost
Copy link

ghost commented Jan 11, 2022

Hello @zadjii-msft!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 6b65713 into main Jan 11, 2022
@ghost ghost deleted the dev/migrie/b/11371-bump-min-version branch January 11, 2022 17:56
@phil-blain
Copy link

phil-blain commented Feb 2, 2022

Hello, I noticed that the minimum version mentioned in the README was not updated:

terminal/README.md

Lines 22 to 25 in d07c536

## Installing and running Windows Terminal
> 🔴 Note: Windows Terminal requires Windows 10 1903 (build 18362) or later

It's also mentioned later on in the developer setup requirements:

terminal/README.md

Lines 283 to 288 in d07c536

## Developer Guidance
## Prerequisites
* You must be running Windows 1903 (build >= 10.0.18362.0) or later to run
Windows Terminal

zadjii-msft added a commit that referenced this pull request Feb 2, 2022
@zadjii-msft
Update readme to account for minversion bump
7265a3e 
As noticed in #12129 (comment). 

Missed in #12129.
@zadjii-msft zadjii-msft mentioned this pull request Feb 2, 2022
Merged
DHowett pushed a commit that referenced this pull request Feb 2, 2022
@zadjii-msft
Update readme to account for minversion bump (#12332)
29e97b6 
As noticed in #12129 (comment). 

Missed in #12129.
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@miniksa miniksa miniksa approved these changes

Assignees

No one assigned

Labels

AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Question For questions or discussion Product-Meta The product is the management of the products.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Terminal 1.13+ requires Windows 20H1 or greater

4 participants

@zadjii-msft @miniksa @phil-blain @carlos-zamora