Merged
Conversation
zadjii-msft
added
Issue-Task
carlos-zamora
approved these changes
Jan 6, 2022
Member
carlos-zamora
left a comment
carlos-zamora
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks!
Member
|
oh, the docs. Update them plz haha |
ghost
requested review from
DHowett,
PankajBhojwani,
leonMSFT,
lhecker and
miniksa
zadjii-msft
added a commit
to MicrosoftDocs/terminal
that referenced
this pull request
Jan 7, 2022
From microsoft/terminal#12097 ## Buffer Exporting ### Export Buffer This allows the user to export the text of the buffer to a file. If the file doesn't exist, it will be created. If the file already exists, its contents will be replaced with the Terminal buffer text. **Command name:** `exportBuffer` **Default bindings:** ```json { "command": { "action": "exportBuffer" } }, ``` #### Actions | Name | Necessity | Accepts | Description | | ---- | --------- | ------- | ----------- | | `path` | Optional | String | If provided, then the Terminal will export the buffer contents to the given file. Otherwise, the Terminal will open a file picker to choose the file to export to. | > [!IMPORTANT] > This feature is only available in [Windows Terminal Preview](https://aka.ms/terminal-preview).
miniksa
approved these changes
Jan 12, 2022
Member
miniksa
left a comment
miniksa
left a comment
There was a problem hiding this comment.
Man it's become a lot easier to do things around here with X macros hasn't it?
| } | ||
| else | ||
| { | ||
| // The file picker isn't going to give us paths with |
Member
There was a problem hiding this comment.
Honestly wouldn't hurt you to call this on either path just in case, but it's fine.
zadjii-msft
added
the
AutoMerge
|
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
12 tasks
|
🎉 Handy links: |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an action for the context menu entry we added in #11062. That PR added support for exporting the buffer, exclusively through the tab item's context menu. This adds an action that can additionally be bound, which also can export the buffer to a file. This action accepts a
pathparam. If empty/ommitted, then the Terminal will prompt for the file to export the buffer to.exportBufferaction (1.13) MicrosoftDocs/terminal#479