Enable resizing the panes with the keyboard.#1207
Merged
zadjii-msft merged 14 commits intomasterfrom Jul 10, 2019
Merged
Conversation
…e size, but doesn't resize down. I also had to remove the seperator. I think I need to have the resize event start from the top, then recurse down
* Works for both vertical and horizontal splits * seperator is visible too * resizing the window works right
If you add keybindings for resizing, like so:
```json
{
"command" : "resizePaneDown",
"keys" :
[
"alt+shift+down"
]
},
{
"command" : "resizePaneLeft",
"keys" :
[
"alt+shift+left"
]
},
{
"command" : "resizePaneRight",
"keys" :
[
"alt+shift+right"
]
},
{
"command" : "resizePaneUp",
"keys" :
[
"alt+shift+up"
]
},
```
Then you can now resize the panes, 5% at a time.
We correctly traverse the tree to find the separator that's closest to the
focused pane (depth-wise), but also the correct direction.
zadjii-msft
added
Area-UserInterface
zadjii-msft
changed the title
zadjii-msft
changed the title
I need the padding fix however
…sizable-panes # Conflicts: # src/cascadia/TerminalApp/AppKeyBindings.cpp # src/cascadia/TerminalApp/AppKeyBindings.h # src/cascadia/TerminalApp/AppKeyBindingsSerialization.cpp
Contributor
|
If you have this layout: and you resize |
Member
Yup. Pretty neat :) |
Member
Author
|
@DHowett-MSFT you bet it does :) |
But that might always have been broken
Also add comments
carlos-zamora
approved these changes
Jun 19, 2019
dlong11
reviewed
Jun 22, 2019
dlong11
reviewed
Jun 22, 2019
dlong11
reviewed
Jun 22, 2019
Member
Author
|
@adiviness @DHowett-MSFT @miniksa Can I get a second on this at some point? I'll have another PR to follow this one for moving pane focus |
miniksa
requested changes
Jul 1, 2019
Member
miniksa
left a comment
miniksa
left a comment
There was a problem hiding this comment.
I see a few things and there are a few open comments still in here from other folks.
ghost
added
the
Needs-Author-Feedback
…sizable-panes # Conflicts: # src/cascadia/TerminalApp/App.cpp
ghost
removed
the
Needs-Author-Feedback
miniksa
approved these changes
Jul 5, 2019
DHowett-MSFT
approved these changes
Jul 10, 2019
Contributor
DHowett-MSFT
left a comment
DHowett-MSFT
left a comment
There was a problem hiding this comment.
Sorry we took so long!
…sizable-panes # Conflicts: # src/cascadia/TerminalApp/App.cpp
59 tasks
mcpiroman
pushed a commit
to mcpiroman/terminal
that referenced
this pull request
Jul 23, 2019
Adds the ability to resize panes with the keyboard.
This is accomplished by making the Column/RowDefinitions for a Pane use `GridLengthHelper::FromPixels` to set their size. We store a pair of floats that represents the relative amount that each pane takes out of the parent pane. When the window is resized, we use that percentage to figure out the new size of each child in pixels, and manually size each column.
Then, when the user presses the keybindings for resizePane{Left/Right/Up/Down}, we'll adjust those percentages, and resize the rows/cols as appropriate.
Currently, each pane adjusts the width/height by 5% of the total size at a time. I am not in love with this, but it works for now. I think when we get support for keybindings with arbitrary arg blobs, then we could do either a percent movement, or a number of characters at a time. The number of characters one would be trickier, because we'd have to get the focused control, and get the number of pixels per character, as adjacent panes might not have the same font sizes.
|
🎉 Handy links: |
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Adds the ability to resize panes with the keyboard.
PR Checklist
Detailed Description of the Pull Request / Additional comments
This is accomplished by making the Column/RowDefinitions for a Pane use
GridLengthHelper::FromPixelsto set their size. We store a pair of floats that represents the relative amount that each pane takes out of the parent pane. When the window is resized, we use that percentage to figure out the new size of each child in pixels, and manually size each column.Then, when the user presses the keybindings for resizePane{Left/Right/Up/Down}, we'll adjust those percentages, and resize the rows/cols as appropriate.
Currently, each pane adjusts the width/height by 5% of the total size at a time. I am not in love with this, but it works for now. I think when we get support for keybindings with arbitrary arg blobs, then we could do either a percent movement, or a number of characters at a time. The number of characters one would be trickier, because we'd have to get the focused control, and get the number of pixels per character, as adjacent panes might not have the same font sizes.
Validation Steps Performed
Opened a bunch of panes and tried moving them with the keybindings