Skip to content

Only look for PGO package if build mode targeted; add packages.config dependency to ease restoration#11981

Merged
2 commits merged intomainfrom
dev/miniksa/nuget_oop
Dec 16, 2021
Merged

Only look for PGO package if build mode targeted; add packages.config dependency to ease restoration#11981
2 commits merged intomainfrom
dev/miniksa/nuget_oop

Conversation

@miniksa
Copy link
Member

@miniksa miniksa commented Dec 16, 2021 •
edited
Loading

Only look for PGO package if build mode targeted; add packages.config dependency to ease restoration

PR Checklist

@miniksa
Copy link
Member Author

miniksa commented Dec 16, 2021 •
edited
Loading 

git clone https://github.com/microsoft/terminal tf
cd tf
git submodule update --init --recursive
git checkout dev/miniksa/nuget_oop
nuget restore openConsole.sln
msbuild OpenConsole.sln /p:Platform=x64 /p:Configuration=Debug /m /bl:foo.binlog

lgtm

@miniksa miniksa added the AutoMerge Marked for automatic merge by the bot when requirements are met label Dec 16, 2021
@ghost
Copy link

ghost commented Dec 16, 2021

Hello @miniksa!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 7 hours 37 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@miniksa
Copy link
Member Author

miniksa commented Dec 16, 2021

@msftbot wait 20 minutes then merge

@ghost
Copy link

ghost commented Dec 16, 2021

Hello @miniksa!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Thu, 16 Dec 2021 22:17:33 GMT, which is in 20 minutes

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@miniksa miniksa mentioned this pull request Dec 16, 2021
Closed
@ghost ghost merged commit 1e22bfa into main Dec 16, 2021
@ghost ghost deleted the dev/miniksa/nuget_oop branch December 16, 2021 22:18
miniksa added a commit that referenced this pull request Jan 10, 2022
@miniksa
After #11981, I need to set Instrument here for the props to be loade…
2e9353f 
…d correctly while making the nuget.
miniksa added a commit that referenced this pull request Jan 10, 2022
@miniksa
Only look for PGO package if build mode targeted; add packages.config…
db5ddcc 
… dependency to ease restoration (#11981)

Only look for PGO package if build mode targeted; add packages.config dependency to ease restoration

## PR Checklist
* [x] Closes #11978 
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA
* [x] Test of restore and build on fresh repo copy passed.
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DHowett DHowett DHowett approved these changes

@lhecker lhecker lhecker approved these changes

Assignees

No one assigned

Labels

AutoMerge Marked for automatic merge by the bot when requirements are met

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unable to build main following "Move to PGO Nuget" change

3 participants

@miniksa @DHowett @lhecker