Double and Triple Click Selection#1197
Merged
carlos-zamora merged 17 commits intomasterfrom Jul 11, 2019
Merged
Conversation
zadjii-msft
reviewed
Jun 11, 2019
Bugfix (double click after scrolling would go out of bounds)
dlong11
reviewed
Jun 12, 2019
dlong11
reviewed
Jun 12, 2019
zadjii-msft
reviewed
Jun 13, 2019
zadjii-msft
approved these changes
Jun 14, 2019
This was referenced Jun 14, 2019
Closed
miniksa
requested changes
Jun 28, 2019
Member
miniksa
left a comment
There was a problem hiding this comment.
There's one odd thing with the triple click check that I want to see your answer to before signing off.
Member
Author
|
Once #1273 gets merged in, I'm gonna do a bit of refactoring too. I want to move most/all of the changes in |
DHowett-MSFT
reviewed
Jul 9, 2019
miniksa
reviewed
Jul 10, 2019
miniksa
approved these changes
Jul 10, 2019
Member
miniksa
left a comment
There was a problem hiding this comment.
Approved, but please fix the seconds/milliseconds comment mismatch before merging.
DHowett-MSFT
suggested changes
Jul 10, 2019
Import System double click time rename `_DoubleClickDelimiterCheck`
DHowett-MSFT
suggested changes
Jul 11, 2019
mcpiroman
pushed a commit
to mcpiroman/terminal
that referenced
this pull request
Jul 23, 2019
mcpiroman
pushed a commit
to mcpiroman/terminal
that referenced
this pull request
Jul 23, 2019
|
🎉 Handy links: |
This was referenced Aug 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Initial double click selection works. So a double click will make a selection within some preset delimiters (' ', '/' '\'). The left side excludes the delimiter. The right side includes it.
Initial triple click selection works. Selects the entire line.
The following known issues will be implemented in separate PRs.
Known Issues:
References
#1084 Screenshot Selection: one step closer to this. Now just need to create it and attach it as a configurable option to triple click
#988 Double Click Selection: needs ChunkSelection + Settings before completion
#989 Triple Click Selection: needs ChunkSelection + Settings before completion
PR Checklist
Detailed Description of the Pull Request / Additional comments
TermControl Changes
Terminal Changes
Validation Steps Performed
You can actually do most with the header on startup :).