Skip to content

Make sure to deserialize arg params _before_ validating#11892

Merged
1 commit merged intomainfrom
dev/migrie/eim/oops-all-berries
Dec 7, 2021
Merged

Make sure to deserialize arg params _before_ validating#11892
1 commit merged intomainfrom
dev/migrie/eim/oops-all-berries

Conversation

@zadjii-msft
Copy link
Member

@zadjii-msft zadjii-msft commented Dec 7, 2021 •
edited
Loading

I had these out of order, and apparently forgot to launch the Terminal before pushing that commit. This resulted in getting the following with the default settings:
image

So yea obviously, we should deserialize first, then check if the setting is valid.

@zadjii-msft zadjii-msft added Area-Settings Issues related to settings and customizability, for console or terminal Priority-0 Bugs that we consider release-blocking/recall-class (P0) labels Dec 7, 2021
@zadjii-msft zadjii-msft linked an issue Dec 7, 2021 that may be closed by this pull request
Encountered errors while loading user settings with 3606c3d #11896
Closed
This was referenced Dec 7, 2021
Closed
Closed
@lhecker lhecker added the AutoMerge Marked for automatic merge by the bot when requirements are met label Dec 7, 2021
@ghost
Copy link

ghost commented Dec 7, 2021

Hello @lhecker!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 3 hours 12 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@zadjii-msft
Copy link
Member Author

zadjii-msft commented Dec 7, 2021

@msftbot merge this in 1 minute

@ghost
Copy link

ghost commented Dec 7, 2021

Hello @zadjii-msft!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Tue, 07 Dec 2021 17:58:44 GMT, which is in 1 minute

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@ghost ghost merged commit 35b633e into main Dec 7, 2021
@ghost ghost deleted the dev/migrie/eim/oops-all-berries branch December 7, 2021 17:59
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lhecker lhecker lhecker approved these changes

@carlos-zamora carlos-zamora carlos-zamora approved these changes

Assignees

No one assigned

Labels

Area-Settings Issues related to settings and customizability, for console or terminal AutoMerge Marked for automatic merge by the bot when requirements are met Priority-0 Bugs that we consider release-blocking/recall-class (P0)

Projects

None yet

Milestone

Engineering Improvements 2021

Development

Successfully merging this pull request may close these issues.

Encountered errors while loading user settings with 3606c3d Warnings found while parsing your keybindings

3 participants

@zadjii-msft @lhecker @carlos-zamora