Skip to content

Fix AltGr+Space not working#11832

Merged
zadjii-msft merged 1 commit intorelease-1.11from
dev/lhecker/issue-11649-alt-space
Dec 1, 2021
Merged

Fix AltGr+Space not working#11832
zadjii-msft merged 1 commit intorelease-1.11from
dev/lhecker/issue-11649-alt-space

Conversation

@lhecker
Copy link
Member

@lhecker lhecker commented Nov 27, 2021

This fixes a regression introduced in #10988 for the 1.11 release branch.
For later branches this issue was fixed in #11086.

PR Checklist

Validation Steps Performed

  • AltGr+Space produces "_" with the bépo keyboard layout

@ghost ghost added Area-Input Related to input processing (key presses, mouse, etc.) Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. labels Nov 27, 2021
@zadjii-msft zadjii-msft added the AutoMerge Marked for automatic merge by the bot when requirements are met label Nov 29, 2021
@ghost
Copy link

ghost commented Nov 29, 2021

Hello @zadjii-msft!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Nov 29, 2021

Apologies, while this PR appears ready to be merged, it looks like release-1.11 is a protected branch and I have not been granted permission to perform the merge.

@zadjii-msft zadjii-msft merged commit 2bd3768 into release-1.11 Dec 1, 2021
@zadjii-msft zadjii-msft deleted the dev/lhecker/issue-11649-alt-space branch December 1, 2021 11:38
@ghost
Copy link

ghost commented Dec 14, 2021

🎉Windows Terminal v1.11.3471.0 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Input Related to input processing (key presses, mouse, etc.) Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants