Remove unused rendering settings from profile#11685
Merged
Conversation
zadjii-msft
approved these changes
Nov 4, 2021
DHowett
approved these changes
Nov 4, 2021
Member
DHowett
left a comment
DHowett
left a comment
There was a problem hiding this comment.
Let me guess: these failed to build because of the _OpenSettingsUI thing?
Member
|
Build log confirms -- Terminal.Settings.Model.dll still builds. I'm admin-merging this to avoid another signoff cycle./ |
DHowett
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ForceFullRepaintRenderingandSoftwareRenderingare global only and for some reason were in profile. This commit removes them.Reference: #11416 (comment)