Ignore newTab actions with a profile index greater than the number of profiles#11621
Merged
3 commits merged intomainfrom May 5, 2022
Merged
Ignore newTab actions with a profile index greater than the number of profiles#116213 commits merged intomainfrom
newTab actions with a profile index greater than the number of profiles#116213 commits merged intomainfrom
Conversation
ghost
added
Area-Settings
DHowett
approved these changes
Oct 26, 2021
Member
|
Sure, let's do it! |
ghost
requested review from
PankajBhojwani,
carlos-zamora,
leonMSFT,
lhecker and
miniksa
PankajBhojwani
approved these changes
Oct 26, 2021
| { | ||
| if (index >= _settings->ActiveProfiles().Size()) | ||
| { | ||
| args.Handled(false); |
There was a problem hiding this comment.
What's the effect of false here? I would greatly prefer that the set of key combinations passed to the conpty not depend on how many profiles are defined.
raghavthind2005
approved these changes
Apr 26, 2022
zadjii-msft
added
the
AutoMerge
|
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
carlos-zamora
pushed a commit
that referenced
this pull request
May 12, 2022
…of profiles (#11621) ## Summary of the Pull Request As discussed in team sync. Ignore `newTab` actions with a profile index greater than the number of profiles. ## PR Checklist * [x] Closes #11114 * [x] I work here * [ ] Tests added/passed * [ ] Requires documentation to be updated - maybe❓ (cherry picked from commit ce850ca) Service-Card-Id: 81744839 Service-Version: 1.13
|
🎉 Handy links: |
ghost
mentioned this pull request
|
🎉 Handy links: |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
As discussed in team sync. Ignore
newTabactions with a profile index greater than the number of profiles.PR Checklist